Handle createLink post security manager in StoreRecoveryTests #129964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running under security manager an assumptionw as made that failing to create a hard link due to security exception implied hard links were supported. Now that security manager is gone, the code to create a hard link in StoreRecoveryTests executes. But in the case of windows, BasicFileAttributes.fileKey does not return a unique object that can be used to verify a link exists. Yet the fact createLink returned is enough to trust the jdk was able to create a link. closes elastic#124104
rjernst
added
>test
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
lkts
approved these changes
Jun 26, 2025
Member
Author
|
@elasticmachine update branch |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…c#129964) When running under security manager an assumptionw as made that failing to create a hard link due to security exception implied hard links were supported. Now that security manager is gone, the code to create a hard link in StoreRecoveryTests executes. But in the case of windows, BasicFileAttributes.fileKey does not return a unique object that can be used to verify a link exists. Yet the fact createLink returned is enough to trust the jdk was able to create a link. closes elastic#124104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under security manager an assumption was made that failing to create a hard link due to security exception implied hard links were supported. Now that security manager is gone, the code to create a hard link in StoreRecoveryTests executes. But in the case of windows, BasicFileAttributes.fileKey does not return a unique object that can be used to verify a link exists. Yet the fact createLink returned is enough to trust the jdk was able to create a link.
closes #124104